sage.geometry.polyhedron: fix doctest error due to modularization
#36089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
approved these changes
Aug 13, 2023
|
Documentation preview for this PR (built with commit fc72523; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 23, 2023
…o modularization
On MacOS with sagemath 10.1.rc0, I have the following doctest error in
`src/sage/geometry/polyhedron/base_ZZ.py`
```
sage -t --long --warn-long 18.5 --random-
seed=240228246560107174999702016603267109757
src/sage/geometry/polyhedron/base_ZZ.py
**********************************************************************
File "src/sage/geometry/polyhedron/base_ZZ.py", line 419, in
sage.geometry.polyhedron.base_ZZ.Polyhedron_ZZ.?
Failed example:
hypercube(3).ehrhart_polynomial(engine='normaliz')
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/src/sage/doctest/forker.py", line 709,
in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/src/sage/doctest/forker.py", line 1144,
in compile_and_execute
exec(compiled, globs)
File "<doctest
sage.geometry.polyhedron.base_ZZ.Polyhedron_ZZ.?[9]>", line 1, in
<module>
hypercube(Integer(3)).ehrhart_polynomial(engine='normaliz')
^^^^^^^^^^^^^^^^^^^^^
File "<doctest
sage.geometry.polyhedron.base_ZZ.Polyhedron_ZZ.?[8]>", line 2, in
hypercube
return Polyhedron(vertices=list(product([Integer(0),Integer(1)],
repeat=d)),backend='normaliz')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'sage.rings.integer.Integer' object is not iterable
**********************************************************************
File "src/sage/geometry/polyhedron/base_ZZ.py", line 421, in
sage.geometry.polyhedron.base_ZZ.Polyhedron_ZZ.?
Failed example:
hypercube(4).ehrhart_polynomial(engine='normaliz')
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/src/sage/doctest/forker.py", line 709,
in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/src/sage/doctest/forker.py", line 1144,
in compile_and_execute
exec(compiled, globs)
File "<doctest
sage.geometry.polyhedron.base_ZZ.Polyhedron_ZZ.?[10]>", line 1, in
<module>
hypercube(Integer(4)).ehrhart_polynomial(engine='normaliz')
^^^^^^^^^^^^^^^^^^^^^
File "<doctest
sage.geometry.polyhedron.base_ZZ.Polyhedron_ZZ.?[8]>", line 2, in
hypercube
return Polyhedron(vertices=list(product([Integer(0),Integer(1)],
repeat=d)),backend='normaliz')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'sage.rings.integer.Integer' object is not iterable
**********************************************************************
File "src/sage/geometry/polyhedron/base_ZZ.py", line 423, in
sage.geometry.polyhedron.base_ZZ.Polyhedron_ZZ.?
Failed example:
hypercube(5).ehrhart_polynomial(engine='normaliz')
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/src/sage/doctest/forker.py", line 709,
in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/src/sage/doctest/forker.py", line 1144,
in compile_and_execute
exec(compiled, globs)
File "<doctest
sage.geometry.polyhedron.base_ZZ.Polyhedron_ZZ.?[11]>", line 1, in
<module>
hypercube(Integer(5)).ehrhart_polynomial(engine='normaliz')
^^^^^^^^^^^^^^^^^^^^^
File "<doctest
sage.geometry.polyhedron.base_ZZ.Polyhedron_ZZ.?[8]>", line 2, in
hypercube
return Polyhedron(vertices=list(product([Integer(0),Integer(1)],
repeat=d)),backend='normaliz')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'sage.rings.integer.Integer' object is not iterable
**********************************************************************
File "src/sage/geometry/polyhedron/base_ZZ.py", line 425, in
sage.geometry.polyhedron.base_ZZ.Polyhedron_ZZ.?
Failed example:
hypercube(6).ehrhart_polynomial(engine='normaliz')
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/src/sage/doctest/forker.py", line 709,
in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/src/sage/doctest/forker.py", line 1144,
in compile_and_execute
exec(compiled, globs)
File "<doctest
sage.geometry.polyhedron.base_ZZ.Polyhedron_ZZ.?[12]>", line 1, in
<module>
hypercube(Integer(6)).ehrhart_polynomial(engine='normaliz')
^^^^^^^^^^^^^^^^^^^^^
File "<doctest
sage.geometry.polyhedron.base_ZZ.Polyhedron_ZZ.?[8]>", line 2, in
hypercube
return Polyhedron(vertices=list(product([Integer(0),Integer(1)],
repeat=d)),backend='normaliz')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'sage.rings.integer.Integer' object is not iterable
```
This is caused by the `from itertools import product` in a block
starting with `# optional - latte_int`. Apparently I don't have
`latte_int` installed, and so this import is not done when starting the
block with `pynormaliz` (I have it). So the fix is trivial.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36089
Reported by: David Coudert
Reviewer(s): Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS with sagemath 10.1.rc0, I have the following doctest error in
src/sage/geometry/polyhedron/base_ZZ.pyThis is caused by the
from itertools import productin a block starting with# optional - latte_int. Apparently I don't havelatte_intinstalled, and so this import is not done when starting the block withpynormaliz(I have it). So the fix is trivial.📝 Checklist
⌛ Dependencies