Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using mute variables in combinat #36107

Merged
merged 4 commits into from
Aug 27, 2023
Merged

using mute variables in combinat #36107

merged 4 commits into from
Aug 27, 2023

Conversation

fchapoton
Copy link
Contributor

taking care of unused variables found by pylint in combinat

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@fchapoton
Update sloane_functions.py
a0fd815 
using Partitions
dcoudert
dcoudert suggested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, LGTM.

src/sage/combinat/yang_baxter_graph.py Outdated Show resolved Hide resolved
@github-actions
Copy link

Documentation preview for this PR (built with commit 613a287; changes) is ready! 馃帀

dcoudert
dcoudert approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fchapoton
Copy link
Contributor Author

Merci. Je peux passer en positif, alors ?

@dcoudert
Copy link
Contributor

I was waiting in case @mkoeppe or @mantepse had extra comments.

@vbraun vbraun merged commit 34c505e into sagemath:develop Aug 27, 2023
13 of 14 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Aug 27, 2023
@fchapoton fchapoton deleted the mute_for_unused_vars_in_combi branch August 28, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe left review comments

@mantepse mantepse mantepse left review comments

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
c: combinatorics
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fchapoton @dcoudert @mkoeppe @mantepse @vbraun