Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

using # needs in posets folder #36114

Merged
merged 5 commits into from
Aug 27, 2023
Merged

Conversation

fchapoton
Copy link
Contributor

using the needs directive in posets folder

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@fchapoton
Copy link
Contributor Author

better now ?

@mkoeppe
Copy link
Member

mkoeppe commented Aug 25, 2023

File "sage/combinat/posets/posets.py", line 3719, in sage.combinat.posets.posets.FinitePoset.Integer
Failed example:
    needs sage.groups sage.libs.flint
Exception raised:
    Traceback (most recent call last):
      File "/sage/src/sage/doctest/forker.py", line 709, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/sage/src/sage/doctest/forker.py", line 1142, in compile_and_execute
        compiled = compiler(example)
      File "/sage/src/sage/doctest/forker.py", line 676, in compiler
        code = compile(example.source, filename, "single",
      File "<doctest sage.combinat.posets.posets.FinitePoset.Integer[0]>", line 1
        needs sage.groups sage.libs.flint
              ^
    SyntaxError: invalid syntax
**********************************************************************
File "sage/combinat/posets/posets.py", line [37](https://github.com/sagemath/sage/actions/runs/5978963391/job/16222089762?pr=36114#step:14:38)37, in sage.combinat.posets.posets.FinitePoset.Integer
Failed example:
    needs sage.groups sage.libs.flint
Exception raised:
    Traceback (most recent call last):
      File "/sage/src/sage/doctest/forker.py", line 709, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/sage/src/sage/doctest/forker.py", line 1142, in compile_and_execute
        compiled = compiler(example)
      File "/sage/src/sage/doctest/forker.py", line 676, in compiler
        code = compile(example.source, filename, "single",
      File "<doctest sage.combinat.posets.posets.FinitePoset.Integer[8]>", line 1
        needs sage.groups sage.libs.flint
              ^
    SyntaxError: invalid syntax

needs needs #

@github-actions
Copy link

Documentation preview for this PR (built with commit b42148c; changes) is ready! 馃帀

Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@mkoeppe mkoeppe changed the title using needs in posets folder using # needs in posets folder Aug 26, 2023
@vbraun vbraun merged commit 1e6119e into sagemath:develop Aug 27, 2023
11 of 13 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Aug 27, 2023
@fchapoton fchapoton deleted the needs_in_posets branch August 28, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants