Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small improvements for functorial composition #36115

Merged
merged 3 commits into from
Sep 1, 2023
Merged

small improvements for functorial composition #36115

merged 3 commits into from
Sep 1, 2023

Conversation

mantepse
Copy link
Collaborator

@mantepse mantepse commented Aug 22, 2023 •
edited

Fixes #34480

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR (built with commit d86a969; changes) is ready! 🎉

tscrim
tscrim approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tscrim tscrim added this to the sage-10.2 milestone Aug 29, 2023
@vbraun vbraun merged commit 5f56ed5 into sagemath:develop Sep 1, 2023
12 of 13 checks passed
@mantepse mantepse deleted the u/mantepse/small_improvements_for_functorial_composition branch September 1, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: algebra
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

small improvements for functorial composition
3 participants
@mantepse @tscrim @vbraun