Fix two "Computational Math.." book doctests #36143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwankyu
reviewed
Aug 27, 2023
| @@ -253,7 +253,7 @@ | |||
| Sage example in ./integration.tex, line 1363:: | |||
|
|
|||
| sage: t, y = var('t, y') | |||
| sage: desolve_rk4(t*y*(2-y), y, ics=[0,1], end_points=[0, 1], step=0.5) | |||
| sage: desolve_rk4(t*y*(2-y), y, ics=[0,1], end_points=[0, 1], step=0.5) # abs tol 1e-12 | |||
| [[0, 1], [0.5, 1.12419127424558], [1.0, 1.461590162288825]] | |||
There was a problem hiding this comment.
Please two spaces ...) # abs ... instead of one ...) # abs ...
|
Otherwise, lgtm. |
A "Computational Math..." book test fails for me with,
Expected:
[[0, 1], [0.5, 1.12419127424558], [1.0, 1.461590162288825]]
Got:
[[0, 1], [0.5, 1.12419127424558], [1.0, 1.4615901622888245]]
An "abs tol" fixes the issue backwards-compatibly.
One "Computational Math..." book test fails for me with,
Expected:
[[y(x) == -_C^2 + _C*x, y(x) == 1/4*x^2], 'clairault']
Got:
[[y(x) == -_C^2 + _C*x, y(x) == 1/4*x^2], 'clairaut']
This looks like a typo that was fixed. For backwards compatibility,
the doctest has been updated to accept both outputs in the second
component.
orlitzky
force-pushed
the
fix-two-compmath-doctests
branch
from
2684610
to
da754e1
Compare
|
Documentation preview for this PR (built with commit da754e1; changes) is ready! 🎉 |
kwankyu
reviewed
Aug 27, 2023
| sage: solution | ||
| [y(x) == -_C^2 + _C*x, y(x) == 1/4*x^2] | ||
| sage: method in ["clairaut", "clairault"] | ||
| True | ||
|
|
There was a problem hiding this comment.
Do you mean that the typo "clairault" is hard-coded into giac, you expect that it would be fixed in future?
There was a problem hiding this comment.
I'm only guessing that giac is to blame:
- my giac is newer than sage's
- both "clairaut" and "clairault" appear in the giac source code
- there's no changelog for giac
But yes, my guess is that "clairault" was hard-coded somewhere and now it's "clairaut".
|
There is a new failure in Build & Test. I checked that It is unrelated though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing interesting here, just two minor tweaks that are needed probably due to a giac upgrade.