Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coxeter arrangement #36151

Merged
merged 5 commits into from
Sep 10, 2023
Merged

Coxeter arrangement #36151

merged 5 commits into from
Sep 10, 2023

Conversation

fchapoton
Copy link
Contributor

adding the Coxeter arrangement to the catalog

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

@fchapoton
Copy link
Contributor Author

@tscrim , would you please have a look if you have some time ? I am not sure how it relates to your #34936

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Documentation preview for this PR (built with commit ba2fe13; changes) is ready! 馃帀

tscrim
tscrim approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This is basically independent of (but complementary to) #34936 since that deals with the simplicial complexes and corresponding face posets.

@vbraun vbraun merged commit 296643c into sagemath:develop Sep 10, 2023
14 of 15 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 10, 2023
@fchapoton fchapoton deleted the coxeter_arrangement branch September 11, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: combinatorics t: enhancement
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchapoton @tscrim @vbraun @mkoeppe