minor details in graph_plot #36162
Merged
minor details in graph_plot #36162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 24063e1; changes) is ready! 🎉 |
kwankyu
reviewed
Sep 1, 2023
| @@ -168,8 +168,7 @@ | |||
| 'Which graphviz layout program to use -- one of ' | |||
| '"circo", "dot", "fdp", "neato", or "twopi".', | |||
| 'by_component': | |||
| 'Whether to do the spring layout by connected component -- a boolean.', | |||
| } | |||
| 'Whether to do the spring layout by connected component -- a boolean.'} | |||
|
|
|||
There was a problem hiding this comment.
I am not sure if this is an improvement. Is there a standard regarding this?
There was a problem hiding this comment.
this is fixing a pep8 warning issued by pycodestyle, but not one already activated in our linter
|
Otherwise, lgtm. |
kwankyu
approved these changes
Sep 1, 2023
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 2, 2023
just fixing a few little things in the modified file
### 📝 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#36162
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 4, 2023
just fixing a few little things in the modified file
### 📝 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#36162
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 5, 2023
just fixing a few little things in the modified file
### 📝 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#36162
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just fixing a few little things in the modified file
📝 Checklist