sage.groups: Modularization fixes, # needs, doctest cosmetics
#36168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….pyx: Add # optional
dcoudert
reviewed
Sep 3, 2023
There was a problem hiding this comment.
Can we avoid the following warnings ?
sage -t --long --warn-long 33.0 --random-seed=131083448595464797617815522915862346074 src/sage/groups/generic.py
**********************************************************************
File "src/sage/groups/generic.py", line 1233, in sage.groups.generic.?
Warning: Variable 'order_from_multiple' referenced here was set only in doctest marked '# needs sage.rings.finite_rings'
order_from_multiple(w, 230, operation='*')
**********************************************************************
File "src/sage/groups/generic.py", line 1376, in sage.groups.generic.?
Warning: Variable 'order_from_bounds' referenced here was set only in doctest marked '# needs sage.rings.finite_rings'
order_from_bounds(w, (200, 250), operation='*')
[257 tests, 1.87 s]
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 5, 2023
…test cosmetics
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Part of: sagemath#29705
- Cherry-picked from: sagemath#35095
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36168
Reported by: Matthias Köppe
Reviewer(s): David Coudert
|
merge conflict |
|
I'm not sure how to review the addition of the last commits with the broken CI... |
…tools_wheel, not the ancient build/pkgs/setuptools
|
I've merged another PR, which should fix the CI |
|
Documentation preview for this PR (built with commit 02c01f3; changes) is ready! 🎉 |
dcoudert
approved these changes
Sep 15, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies
bootstrap#36240 (merged here)pyproject.tomlfiles #36263 (merged here)