Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the iterator of SemistandardMultiSkewTableaux #36200

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented Sep 7, 2023

Fixes #36196 as the iterator does not update the position as it goes through the word.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 7, 2023

@ghseeli Here is a fix; it was a simple bug.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Documentation preview for this PR (built with commit eed72b2; changes) is ready! 🎉

@ghseeli
Copy link

ghseeli commented Sep 7, 2023

@ghseeli Here is a fix; it was a simple bug.

@tscrim Thank you! I am glad some fixes can be simple :-)

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 8, 2023

@ghseeli Should I interpret that as a positive review? (Due to the new GH process, you can't "officially" set a positive review, which makes the review process much more controlled (to put it very nicely).)

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 10, 2023

Thank you.

@vbraun vbraun merged commit 3441558 into sagemath:develop Sep 10, 2023
18 checks passed
@tscrim tscrim deleted the combinat/smst_iterator_fix-36196 branch September 12, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SemistandardMultiSkewTableaux returns incorrect results
4 participants