build/pkgs/ipython/dependencies: drop jinja2 #36209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also remove it from the run-time dependencies of sagelib? IIRC, it is only used at build time via sage_setup |
|
Also needs to be removed from the install-requires in src/setup.cfg.m4 |
|
merge conflict |
IPython itself no longer depends on jinja2 after nbconvert was factored out of it.
The Sage library needs jinja2 only at build time and only via sage_setup, which is already one of its dependencies.
The Sage library does not itself require jinja2; only sage_setup does.
orlitzky
force-pushed
the
ipython-no-jinja2
branch
from
e151df9
to
6f9fd72
Compare
|
Documentation preview for this PR (built with commit 6f9fd72; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 14, 2023
IPython itself no longer depends on jinja2 after nbconvert was factored
out of it.
URL: sagemath#36209
Reported by: Michael Orlitzky
Reviewer(s): Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPython itself no longer depends on jinja2 after nbconvert was factored out of it.