Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: disable mathjax with --disable-doc #36210

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

orlitzky
Copy link
Contributor

@orlitzky orlitzky commented Sep 7, 2023

Our mathjax package is used only to build the sphinx documentation that can be disabled with --disable-doc. It therefore makes sense to disable the mathjax package along with the other dependencies pruned by --disable-doc.

Our mathjax package is used only to build the sphinx documentation
that can be disabled with --disable-doc. It therefore makes sense
to disable the mathjax package along with the other dependencies
pruned by --disable-doc.
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Documentation preview for this PR (built with commit 86c309a; changes) is ready! 🎉

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I agree.

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 11, 2023
    
Our mathjax package is used only to build the sphinx documentation that
can be disabled with `--disable-doc`. It therefore makes sense to
disable the mathjax package along with the other dependencies pruned by
`--disable-doc`.
    
URL: sagemath#36210
Reported by: Michael Orlitzky
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 14, 2023
    
Our mathjax package is used only to build the sphinx documentation that
can be disabled with `--disable-doc`. It therefore makes sense to
disable the mathjax package along with the other dependencies pruned by
`--disable-doc`.
    
URL: sagemath#36210
Reported by: Michael Orlitzky
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit 322ad22 into sagemath:develop Sep 16, 2023
15 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 16, 2023
@orlitzky orlitzky deleted the disable-mathjax branch September 22, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants