Make min_spanning_tree robust to incomparable vertex labels
#36232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoudert
changed the title
min_spanning_tree robust to vertex labelsmin_spanning_tree robust to incomparable vertex labels
|
Documentation preview for this PR (built with commit 38969d2; changes) is ready! 🎉 |
fchapoton
reviewed
Sep 11, 2023
fchapoton
approved these changes
Sep 12, 2023
fchapoton
approved these changes
Sep 13, 2023
|
Thank you. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 14, 2023
…tex labels
Part of sagemath#35902.
### 📚 Description
We ensure that method `min_spanning_tree` operates properly even when
vertices and edges are of incomparable types.
We are then able to simplify some code in
`src/sage/topology/simplicial_complex.py`.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36232
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35902.
📚 Description
We ensure that method
min_spanning_treeoperates properly even when vertices and edges are of incomparable types.We are then able to simplify some code in
src/sage/topology/simplicial_complex.py.📝 Checklist
⌛ Dependencies