Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.rings.padics: Import fixes (modularization) #36261

Merged
merged 2 commits into from
Oct 8, 2023
Merged

sage.rings.padics: Import fixes (modularization) #36261

merged 2 commits into from
Oct 8, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Sep 13, 2023 •
edited

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Sep 13, 2023
@mkoeppe mkoeppe force-pushed the sage_rings_padics_modularization branch from e1ad014 to 9d8036b Compare September 16, 2023 18:32
@github-actions
Copy link

Documentation preview for this PR (built with commit 9d8036b; changes) is ready! 🎉

dcoudert
dcoudert approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dcoudert dcoudert mentioned this pull request Sep 30, 2023
Merged
2 tasks
@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 30, 2023

Thank you!

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 1, 2023
sagemathgh-36261: sage.rings.padics: Import fixes (modularization)
feb5fc0 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Part of: sagemath#29705
- Cherry-picked from: sagemath#35095
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36261
Reported by: Matthias Köppe
Reviewer(s): David Coudert
@vbraun vbraun merged commit 8ebaeff into sagemath:develop Oct 8, 2023
14 of 16 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: padics t: refactoring
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkoeppe @dcoudert @vbraun