Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.graphs: some care with return ... else statements in some .pyx files #36278

Merged
merged 11 commits into from
Sep 24, 2023
Merged

sage.graphs: some care with return ... else statements in some .pyx files #36278

merged 11 commits into from
Sep 24, 2023

Conversation

dcoudert
Copy link
Contributor

We change this kind of statements in files src/sage/graphs/*.pyx:

if ....:
    return ...
else:
    return ...

to

if ....:
    return ...
return ...

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@dcoudert dcoudert self-assigned this Sep 16, 2023
@github-actions
Copy link

Documentation preview for this PR (built with commit 58af879; changes) is ready! 🎉

kwankyu
kwankyu approved these changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

github-actions[bot]
github-actions bot approved these changes Sep 17, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kwankyu approved this PR

@dcoudert
Copy link
Contributor Author

Thank you.

@vbraun vbraun merged commit 991a463 into sagemath:develop Sep 24, 2023
20 of 22 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees

@dcoudert dcoudert

Labels
c: graph theory t: enhancement
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dcoudert @kwankyu @vbraun @mkoeppe