New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix E228 and E225 in combinat//.py #36280

Merged

vbraun merged 3 commits into sagemath:develop from fchapoton:E228_combinat_step1

Sep 24, 2023

Contributor

fchapoton commented Sep 16, 2023

fix pycodestyle warning E228 and E225 in combinat/*/*.py

done using autopep8

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.


          fix E228 and E225 in combinat/*/*.py

fchapoton added c: combinatorics t: refactoring s: needs review labels

kwankyu reviewed

View reviewed changes

src/sage/combinat/designs/database.py Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/designs/database.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/designs/database.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/designs/database.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/designs/database.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/designs/database.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/designs/database.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/designs/orthogonal_arrays.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/designs/orthogonal_arrays_build_recursive.py Show resolved Hide resolved

Collaborator

kwankyu commented Sep 18, 2023

Otherwise lgtm.


          fix suggested details

22abbb4

Contributor Author

fchapoton commented Sep 18, 2023

thanks a lot, all done

kwankyu reviewed

View reviewed changes

src/sage/combinat/designs/database.py Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/designs/database.py Show resolved Hide resolved


          oops, details fixed

2d0d02c

Contributor Author

fchapoton commented Sep 18, 2023

oops, sorry

kwankyu approved these changes

View reviewed changes

Collaborator

kwankyu left a comment

Thanks.

Assuming tests pass, I set positive review (to test labels :-)

kwankyu added s: positive review and removed s: needs review labels

github-actions bot commented Sep 18, 2023

Documentation preview for this PR (built with commit 2d0d02c; changes) is ready! 🎉

Contributor Author

fchapoton commented Sep 18, 2023

speaking of labels, something funky is happening in #36281

Collaborator

kwankyu commented Sep 18, 2023

It was happening everywhere. Now it seems to have been fixed.

vbraun merged commit 979b368 into sagemath:develop

17 of 18 checks passed

github-actions bot removed the s: positive review label

mkoeppe added this to the sage-10.2 milestone

fchapoton deleted the E228_combinat_step1 branch

September 25, 2023 06:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment