Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using more libgap instead of gap #36297

Merged
merged 3 commits into from
Sep 24, 2023
Merged

using more libgap instead of gap #36297

merged 3 commits into from
Sep 24, 2023

Conversation

fchapoton
Copy link
Contributor

just a few more uses of libgap instead of gap

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

@dimpase dimpase self-requested a review September 19, 2023 08:59
@github-actions
Copy link

Documentation preview for this PR (built with commit 7cb6121; changes) is ready! 馃帀

dimpase
dimpase approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vbraun vbraun merged commit 9311c6d into sagemath:develop Sep 24, 2023
30 of 44 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 24, 2023
@fchapoton fchapoton deleted the more_of_libgap branch September 25, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

Assignees
No one assigned
Labels
c: packages: standard t: refactoring
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchapoton @dimpase @vbraun @mkoeppe