Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated files from src/sage/homology (see #31925) #36300

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

jhpalmieri
Copy link
Member

@jhpalmieri jhpalmieri commented Sep 18, 2023

Remove files from src/sage/homology that were deprecated in #31925.

This is just cleanup: the files were deprecated more than two years ago, and I think we can safely remove them. The deleted files are stubs; the actual code is in files in the directory topology rather than homology.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR (built with commit 17be78e; changes) is ready! 🎉

Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhpalmieri
Copy link
Member Author

Thanks!

@vbraun vbraun merged commit 152cef7 into sagemath:develop Sep 24, 2023
23 of 25 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants