CI: Fix the multi-stage build in ci-linux.yml, fix conda/centos/archlinux system packages #36358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
changed the title
dimpase
approved these changes
Sep 29, 2023
|
Thanks! |
|
This cannot be marked yet as positive review since it has an unreviewed dependency (which in my opinion still needs work). |
|
Nope, also the dependency has a positive review. |
…ing the CI fixes as the DOCKER_TAG
…he python3 depcheck dependencies
…- except on centos-stream-8
…re GH Actions output groups
mkoeppe
force-pushed
the
ci_fix_multistage
branch
from
8018446
to
3f8d4cb
Compare
|
Rebased away from #36348, for natural velocity |
|
Thanks! |
… all standard packages are available
|
Documentation preview for this PR (built with commit def59ae; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 1, 2023
…conda/centos/archlinux system packages
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Fixes breakage from sagemath#36338 seen in https://github.com/sagemath/sage/acti
ons/runs/6332061118/job/17206153694:
The 2nd stage (`...-with-targets`) does not find the container from the
1st stage (`...-with-targets-pre`) because they are keyed to the commit
sha. Fixed here by keying it to the sha before merging the CI fixes.
Also fixing the following failures:
- `conda-forge-minimal` (as seen in https://github.com/sagemath/sage/act
ions/runs/6207962004/job/16858998561); failed because the python3
depcheck packages were missing. Fixed now - check with `tox -e docker-
conda-forge-minimal -- config.status`
- `centos-stream-9-python3.9-minimal` (https://github.com/sagemath/sage/
actions/runs/6207962004/job/16858997494),
`almalinux-9-python3.11-minimal` (https://github.com/sagemath/sage/actio
ns/runs/6207962004/job/16858997663) and `-standard`; fixes sagemath#34786
- `archlinux-standard` - libgiac was missing in at least one run
Also adding a few more uses of GH Action output groups for convenience.
Tests running at https://github.com/mkoeppe/sage/actions/workflows/ci-
linux.yml
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36358
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes breakage from #36338 seen in https://github.com/sagemath/sage/actions/runs/6332061118/job/17206153694:
The 2nd stage (
...-with-targets) does not find the container from the 1st stage (...-with-targets-pre) because they are keyed to the commit sha. Fixed here by keying it to the sha before merging the CI fixes.Also fixing the following failures:
conda-forge-minimal(as seen in https://github.com/sagemath/sage/actions/runs/6207962004/job/16858998561); failed because the python3 depcheck packages were missing. Fixed now - check withtox -e docker-conda-forge-minimal -- config.statuscentos-stream-9-python3.9-minimal(https://github.com/sagemath/sage/actions/runs/6207962004/job/16858997494),almalinux-9-python3.11-minimal(https://github.com/sagemath/sage/actions/runs/6207962004/job/16858997663) and-standard; fixes Fix distro information for _python* on fedora/centos #34786archlinux-standard- libgiac was missing in at least one runAlso adding a few more uses of GH Action output groups for convenience.
Tests running at https://github.com/mkoeppe/sage/actions/workflows/ci-linux.yml
📝 Checklist
⌛ Dependencies