Fix dependencies of packaging, update flit_core to 3.9.0, pip to 23.2.1
#36363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimpase
approved these changes
Sep 29, 2023
dimpase
added
s: positive review
and removed
c: packages: standard
s: needs review
labels
|
Thanks! |
|
Documentation preview for this PR (built with commit 10d98a6; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 1, 2023
… to 3.9.0, `pip` to 23.2.1
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
In a previous upgrade of `packaging`, its build system was changed to
`flit_core`, but we forgot to update the dependencies. This can lead to
errors as seen in `debian-bullseye-standard-sitepackages` (https://githu
b.com/mkoeppe/sage/actions/runs/6344439483/job/17248093225). We fix it
here.
We also upgrade the packages `flit_core` and `pip`.
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36363
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous upgrade of
packaging, its build system was changed toflit_core, but we forgot to update the dependencies. This can lead to errors as seen indebian-bullseye-standard-sitepackages(https://github.com/mkoeppe/sage/actions/runs/6344439483/job/17248093225). We fix it here.We also upgrade the packages
flit_coreandpip.📝 Checklist
⌛ Dependencies