Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libgap cubegroup #36365

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Libgap cubegroup #36365

merged 2 commits into from
Oct 8, 2023

Conversation

fchapoton
Copy link
Contributor

This is refreshing the modified file

  • use libgap instead of gap
  • use unicode for display
  • a few other small details

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

@github-actions
Copy link

Documentation preview for this PR (built with commit ccd9ec0; changes) is ready! 馃帀

dcoudert
dcoudert approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dcoudert
Copy link
Contributor

dcoudert commented Oct 2, 2023

The display is much nicer this way.

@vbraun vbraun merged commit 1af197b into sagemath:develop Oct 8, 2023
20 of 22 checks passed
@fchapoton fchapoton deleted the libgap_cubegroup branch October 8, 2023 14:35
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
c: group theory
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchapoton @dcoudert @vbraun @mkoeppe