Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remaining W605 warnings in pxi files #36371

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

fchapoton
Copy link
Contributor

This is fixing the few remaining W605 warnings issued by cython-lint, in some pxi files.

This is outside of rings/padics, handled in another place.

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

``base`` -- a subfield of the parent `L` of this element.
The norm is the relative norm from ``L`` to ``base``.
Defaults to the absolute norm down to `\QQ_p` or `\ZZ_p`.
``base`` -- a subfield of the parent `L` of this element.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be like

- ``base`` -- ...

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

LGTM.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Documentation preview for this PR (built with commit ec9ac7f; changes) is ready! 馃帀

@vbraun vbraun merged commit 17f07d5 into sagemath:develop Oct 8, 2023
19 of 20 checks passed
@fchapoton fchapoton deleted the fix-few-W605-pxi branch October 8, 2023 14:35
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants