trying ruff on some posets files #36440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 9a9bb58; changes) is ready! 馃帀 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 15, 2023
This is changing two files in the posets folder.
- use a smaller doctest in one place
- replace one annoying use of `deepcopy` by the method `copy` of
`DiGraph`
- apply `ruff check --fix --select UP src/sage/combinat/posets` to make
a few automatic modifications, about strings mostly, and about the
syntax of `super`
- avoid one symbolic number in one doctest
### 馃摑 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#36440
Reported by: Fr茅d茅ric Chapoton
Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 17, 2023
This is changing two files in the posets folder.
- use a smaller doctest in one place
- replace one annoying use of `deepcopy` by the method `copy` of
`DiGraph`
- apply `ruff check --fix --select UP src/sage/combinat/posets` to make
a few automatic modifications, about strings mostly, and about the
syntax of `super`
- avoid one symbolic number in one doctest
### 馃摑 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#36440
Reported by: Fr茅d茅ric Chapoton
Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is changing two files in the posets folder.
deepcopyby the methodcopyofDiGraphruff check --fix --select UP src/sage/combinat/posetsto make a few automatic modifications, about strings mostly, and about the syntax ofsuper馃摑 Checklist