Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tomli from some build dependencies #36454

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Oct 12, 2023

No longer needed because our current version of flit_core vendors it.

Also eliminates one use of --no-build-isolation.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 14, 2023

flit_core installs tomli-w, instead of tomli. Is this only needed?

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 17, 2023

flit_core installs tomli-w

I don't think it does; more info?

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 17, 2023

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 17, 2023

That's what https://pypi.org/project/flit-core/ leads me to.

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 17, 2023

In that source tree, flit-core is found in the subdirectory https://github.com/pypa/flit/tree/main/flit_core; so https://github.com/pypa/flit/blob/main/flit_core/pyproject.toml is the relevant file.

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 17, 2023

Ah, thanks.

The relevant file has only dependencies = []. Then "flit_core vendors tomli"?

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 17, 2023

flit_core vendors tomli

Yes, see https://github.com/pypa/flit/tree/main/flit_core/flit_core/vendor

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 17, 2023

I see. tomli is included. Thanks!

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sage builds well.

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 17, 2023

Thanks!

@vbraun vbraun merged commit 2ef76f3 into sagemath:develop Oct 21, 2023
22 of 33 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants