Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a hash function for the class TernaryQF. #36553

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Add a hash function for the class TernaryQF. #36553

merged 1 commit into from
Oct 31, 2023

Conversation

tornaria
Copy link
Contributor

@tornaria tornaria commented Oct 26, 2023 •
edited

PR from #16956 (rebased from sagemath/sagetrac-mirror@091cbbd)

Author: Gustavo Rama

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 28, 2023
sagemathgh-36553: Add a hash function for the class TernaryQF.
64b399a 
PR from sagemath#16956 (rebased from https://github.com/sagemath/sagetrac-
mirror/commit/091cbbdf6eed2c8bccca407addd07ff08e429c17)

Author: Gustavo Rama

### 馃摑 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

URL: sagemath#36553
Reported by: Gonzalo Tornar铆a
Reviewer(s):
@vbraun
Copy link
Member

vbraun commented Oct 29, 2023

On 32-bit:

**********************************************************************
File "src/sage/quadratic_forms/ternary_qf.py", line 126, in sage.quadratic_forms.ternary_qf.TernaryQF.__hash__
Failed example:
    Q.__hash__()
Expected:
    5881802312257552497
Got:
    1770036893
**********************************************************************

@github-actions
Copy link

Documentation preview for this PR (built with commit f6fee14; changes) is ready! 馃帀

@vbraun vbraun merged commit f5bdda9 into sagemath:develop Oct 31, 2023
20 of 21 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 31, 2023
@tornaria tornaria deleted the hash_function_for_ternaryqf branch November 2, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: quadratic forms
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tornaria @vbraun @mkoeppe