sage -t --format github (illustration)
#36558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
force-pushed
the
doctester-github-annotations
branch
from
e7d9fa4
to
16e6077
Compare
mkoeppe
force-pushed
the
doctester-github-annotations
branch
2 times, most recently
from
c23546e
to
35b991c
Compare
mkoeppe
force-pushed
the
doctester-github-annotations
branch
from
35b991c
to
1849493
Compare
mkoeppe
changed the title
sage -t --format githubsage -t --format github (illustration)
5 tasks
Merged
5 tasks
…hub-annotations--prod
5 tasks
…mework' baseline-aware
…hub-annotations--prod
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 27, 2023
…seline]' earlier
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
The note "[failed in baseline]" already appears in the doctest failure
summary.
Here we add the note also to the `sage -t` line during doctesting:
https://github.com/sagemath/sage/actions/runs/7281940815/job/19843412065
?pr=36936#step:11:2744
```
sage -t --random-seed=256963700569517996050547927079750684585
src/sage/combinat/combinatorial_map.py
[75 tests, 0.05 s]
sage -t --random-seed=256963700569517996050547927079750684585
src/sage/combinat/cluster_algebra_quiver/quiver.py # [failed in
baseline]
[320 tests, 3.73 s]
sage -t --random-seed=256963700569517996050547927079750684585
src/sage/combinat/composition_signed.py
[20 tests, 0.16 s]
```
https://github.com/sagemath/sage/actions/runs/7281940815/job/19843412065
?pr=36936#step:11:9192
```
sage -t --random-seed=256963700569517996050547927079750684585
src/sage_setup/setenv.py
[0 tests, 0.00 s]
sage -t --random-seed=256963700569517996050547927079750684585
src/sage_setup/clean.py # [failed in baseline]
**********************************************************************
File "src/sage_setup/clean.py", line 104, in
sage_setup.clean._find_stale_files
Failed example:
for f in stale_iter:
if f.endswith(skip_extensions): continue
if '/ext_data/' in f: continue
print('Found stale file: ' + f)
Expected nothing
Got:
Found stale file: sage/tests/books/judson-abstract-
algebra/homomorph-sage-exercises.py
Found stale file: sage/tests/books/judson-abstract-algebra/actions-
sage-exercises.py
Found stale file: sage/tests/books/judson-abstract-
algebra/homomorph-sage.py
```
The changes in the code that implement this are also preparation for:
- sagemath#36558.
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [ ] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36936
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
… tests of the new files, to avoid duplication
|
This looks extremely useful -- thanks! |
…\n, pad short multi-line messages
…path '.coverage/'"
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 2, 2024
…seline]' earlier
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
The note "[failed in baseline]" already appears in the doctest failure
summary.
Here we add the note also to the `sage -t` line during doctesting:
https://github.com/sagemath/sage/actions/runs/7281940815/job/19843412065
?pr=36936#step:11:2744
```
sage -t --random-seed=256963700569517996050547927079750684585
src/sage/combinat/combinatorial_map.py
[75 tests, 0.05 s]
sage -t --random-seed=256963700569517996050547927079750684585
src/sage/combinat/cluster_algebra_quiver/quiver.py # [failed in
baseline]
[320 tests, 3.73 s]
sage -t --random-seed=256963700569517996050547927079750684585
src/sage/combinat/composition_signed.py
[20 tests, 0.16 s]
```
https://github.com/sagemath/sage/actions/runs/7281940815/job/19843412065
?pr=36936#step:11:9192
```
sage -t --random-seed=256963700569517996050547927079750684585
src/sage_setup/setenv.py
[0 tests, 0.00 s]
sage -t --random-seed=256963700569517996050547927079750684585
src/sage_setup/clean.py # [failed in baseline]
**********************************************************************
File "src/sage_setup/clean.py", line 104, in
sage_setup.clean._find_stale_files
Failed example:
for f in stale_iter:
if f.endswith(skip_extensions): continue
if '/ext_data/' in f: continue
print('Found stale file: ' + f)
Expected nothing
Got:
Found stale file: sage/tests/books/judson-abstract-
algebra/homomorph-sage-exercises.py
Found stale file: sage/tests/books/judson-abstract-algebra/actions-
sage-exercises.py
Found stale file: sage/tests/books/judson-abstract-
algebra/homomorph-sage.py
```
The changes in the code that implement this are also preparation for:
- sagemath#36558.
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [ ] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36936
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
…-annotations--prod
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 5, 2024
…seline]' earlier
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
The note "[failed in baseline]" already appears in the doctest failure
summary.
Here we add the note also to the `sage -t` line during doctesting:
https://github.com/sagemath/sage/actions/runs/7281940815/job/19843412065
?pr=36936#step:11:2744
```
sage -t --random-seed=256963700569517996050547927079750684585
src/sage/combinat/combinatorial_map.py
[75 tests, 0.05 s]
sage -t --random-seed=256963700569517996050547927079750684585
src/sage/combinat/cluster_algebra_quiver/quiver.py # [failed in
baseline]
[320 tests, 3.73 s]
sage -t --random-seed=256963700569517996050547927079750684585
src/sage/combinat/composition_signed.py
[20 tests, 0.16 s]
```
https://github.com/sagemath/sage/actions/runs/7281940815/job/19843412065
?pr=36936#step:11:9192
```
sage -t --random-seed=256963700569517996050547927079750684585
src/sage_setup/setenv.py
[0 tests, 0.00 s]
sage -t --random-seed=256963700569517996050547927079750684585
src/sage_setup/clean.py # [failed in baseline]
**********************************************************************
File "src/sage_setup/clean.py", line 104, in
sage_setup.clean._find_stale_files
Failed example:
for f in stale_iter:
if f.endswith(skip_extensions): continue
if '/ext_data/' in f: continue
print('Found stale file: ' + f)
Expected nothing
Got:
Found stale file: sage/tests/books/judson-abstract-
algebra/homomorph-sage-exercises.py
Found stale file: sage/tests/books/judson-abstract-algebra/actions-
sage-exercises.py
Found stale file: sage/tests/books/judson-abstract-
algebra/homomorph-sage.py
```
The changes in the code that implement this are also preparation for:
- sagemath#36558.
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [ ] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36936
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 13, 2024
…seline]' earlier
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
The note "[failed in baseline]" already appears in the doctest failure
summary.
Here we add the note also to the `sage -t` line during doctesting:
https://github.com/sagemath/sage/actions/runs/7281940815/job/19843412065
?pr=36936#step:11:2744
```
sage -t --random-seed=256963700569517996050547927079750684585
src/sage/combinat/combinatorial_map.py
[75 tests, 0.05 s]
sage -t --random-seed=256963700569517996050547927079750684585
src/sage/combinat/cluster_algebra_quiver/quiver.py # [failed in
baseline]
[320 tests, 3.73 s]
sage -t --random-seed=256963700569517996050547927079750684585
src/sage/combinat/composition_signed.py
[20 tests, 0.16 s]
```
https://github.com/sagemath/sage/actions/runs/7281940815/job/19843412065
?pr=36936#step:11:9192
```
sage -t --random-seed=256963700569517996050547927079750684585
src/sage_setup/setenv.py
[0 tests, 0.00 s]
sage -t --random-seed=256963700569517996050547927079750684585
src/sage_setup/clean.py # [failed in baseline]
**********************************************************************
File "src/sage_setup/clean.py", line 104, in
sage_setup.clean._find_stale_files
Failed example:
for f in stale_iter:
if f.endswith(skip_extensions): continue
if '/ext_data/' in f: continue
print('Found stale file: ' + f)
Expected nothing
Got:
Found stale file: sage/tests/books/judson-abstract-
algebra/homomorph-sage-exercises.py
Found stale file: sage/tests/books/judson-abstract-algebra/actions-
sage-exercises.py
Found stale file: sage/tests/books/judson-abstract-
algebra/homomorph-sage.py
```
The changes in the code that implement this are also preparation for:
- sagemath#36558.
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [ ] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36936
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
…-annotations--prod
|
Documentation preview for this PR (built with commit e8ef307; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 1, 2024
… annotations in the 'Files changed' tab
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
This prints doctest failures as github annotations.
For illustrating this new feature, the branch on sagemath#36558 provokes some
errors.
As seen in the "Files changed" tab over there
(https://github.com/sagemath/sage/pull/36558/files):
- Doctest failures show as errors next to the doctest in source code
- Doctest warnings show as "warnings"
- Doctest failures from files that "failed in baseline" show as
"notices"
These messages can also be seen in the Summary page of the workflow
(https://github.com/sagemath/sage/actions/runs/7359388426?pr=36558).
Clicking on a message leads to the source code location.
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36936
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36938
Reported by: Matthias Köppe
Reviewer(s): Alex J Best, Matthias Köppe, Tobias Diez
|
Closing as #36938 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prints doctest failures as github annotations.
The branch on this PR here provokes some errors for illustration purposes and should not be merged. See #36938 for the actual PR.
As seen in the "Files changed" tab (https://github.com/sagemath/sage/pull/36558/files):
These messages can also be seen in the Summary page of the workflow (https://github.com/sagemath/sage/actions/runs/7282457873?pr=36558). Clicking on a message leads to the source code location.
📝 Checklist
⌛ Dependencies
src/sage/doctest/forker.py: Show '# [failed in baseline]' earlier #36936