Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

care for E702 in fast_arith.pyx #36559

Merged
merged 3 commits into from
Nov 5, 2023
Merged

care for E702 in fast_arith.pyx #36559

merged 3 commits into from
Nov 5, 2023

Conversation

fchapoton
Copy link
Contributor

This is fixing most cython-lint warnings in the modified file, in particular some E702.

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Documentation preview for this PR (built with commit 94e4dc4; changes) is ready! 馃帀

kwankyu
kwankyu approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@vbraun vbraun merged commit 3ee8d4e into sagemath:develop Nov 5, 2023
17 of 18 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 5, 2023
@fchapoton fchapoton deleted the care_for_E702_in_fast_arith branch November 5, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchapoton @kwankyu @vbraun @mkoeppe