Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/sagemath-{bliss,coxeter3,...}: Move metadata from setup.cfg to pyproject.toml #36564

Merged
merged 10 commits into from
Dec 10, 2023
Merged

pkgs/sagemath-{bliss,coxeter3,...}: Move metadata from setup.cfg to pyproject.toml #36564

merged 10 commits into from
Dec 10, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Oct 28, 2023 •
edited

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Oct 28, 2023
@mkoeppe mkoeppe requested a review from kiwifb October 29, 2023 21:00
@kiwifb
Copy link
Member

kiwifb commented Oct 30, 2023

Hum, consequence of removing it from sage_setup. Fair enough. I thought I had reviewed this one already. I guess those PR got mixed up in my head.

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 30, 2023

I think we should put this commit on #36562 instead

@mkoeppe mkoeppe force-pushed the sagemath_bliss_pyproject_toml branch from b060f4d to ad52b86 Compare October 30, 2023 04:38
kiwifb
kiwifb approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@kiwifb kiwifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEt's get this in already. Thought it was done long ago.

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2023

Thank you!

@kiwifb
Copy link
Member

kiwifb commented Dec 6, 2023

We will have to visit the MANIFEST.in again. I noticed a number of sdist includes .m4 files(sagemath-bliss, sagemath-standard for example) and some do include .gitignore (sagemath-standard for example).

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2023

We can do that as part of #36649

@kiwifb
Copy link
Member

kiwifb commented Dec 6, 2023

We can do that as part of #36649

Are you sure that's the right ticket?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Documentation preview for this PR (built with commit bd825f0; changes) is ready! 🎉

@vbraun vbraun merged commit d15e490 into sagemath:develop Dec 10, 2023
19 of 26 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 10, 2023
@mkoeppe mkoeppe mentioned this pull request Dec 31, 2023
Open
@mkoeppe mkoeppe deleted the sagemath_bliss_pyproject_toml branch March 3, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiwifb kiwifb kiwifb approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: distribution p: minor / 4
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkoeppe @kiwifb @vbraun