Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build CI: Fix configuration of coverage upload action #36621

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Nov 1, 2023

Fixes #36620

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link

github-actions bot commented Nov 1, 2023

Documentation preview for this PR (built with commit f800cf8; changes) is ready! 🎉

@tobiasdiez tobiasdiez changed the title .github/workflows/build.yml: Fix configuration of coverage upload action Build CI: Fix configuration of coverage upload action Nov 1, 2023
@tobiasdiez
Copy link
Contributor

Seems to work fine. Thanks. Any idea about what's the issue? Do you add any symlinks in the worktree folder? The underlying issue here might be the same one that also gives the "out of space" exception.

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 1, 2023

Seems to work fine. Thanks.

So let's get it in.

Any idea about what's the issue?

The config was asking to search the whole worktree-image for coverage files.

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be reasonable

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 2, 2023

Thanks!

@vbraun vbraun merged commit 411b000 into sagemath:develop Nov 5, 2023
22 of 23 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 5, 2023
@mkoeppe mkoeppe deleted the ci_coverage_fixup branch December 23, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload coverage fails/takes very long since beta.6
4 participants