clean the file hexad.py #36635
Merged
clean the file hexad.py #36635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoudert
reviewed
Nov 3, 2023
src/sage/games/hexad.py
Outdated
| MINIMOG[0][2], MINIMOG[2][1]) | ||
| if H != []: # must be type 3 | ||
| if H: # must be type 3 | ||
| return list(H), WHAT | ||
| if H == []: # could be type 0 |
There was a problem hiding this comment.
This could be if not H:, or we can remove this test as we checked if H: 2 lines before.
The same situation appears multiple times below.
There was a problem hiding this comment.
voila, merci pour la relecture
dcoudert
approved these changes
Nov 3, 2023
|
Documentation preview for this PR (built with commit 78a16ba; changes) is ready! 馃帀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
various little pep8 details, some fixes by ruff, unicode art, etc
馃摑 Checklist