Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI macOS: Update #36648

Merged
merged 2 commits into from
Nov 10, 2023
Merged

CI macOS: Update #36648

merged 2 commits into from
Nov 10, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Nov 4, 2023

Fixes failure seen in https://github.com/sagemath/sage/actions/runs/6700323362/job/18206090971:

Error: Your Xcode (11.7 => /Applications/Xcode_11.7.app/Contents/Developer) is too outdated.
Please update to Xcode 13.2.1 (or delete it).

Makes the "dist" job work correctly when pushing a non-annotated tag, fixing a failure seen in https://github.com/mkoeppe/sage/actions/runs/6757396979/job/18367916600#step:5:11

Workflow run with this PR: https://github.com/mkoeppe/sage/actions/runs/6757935604

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Nov 4, 2023
Copy link

github-actions bot commented Nov 4, 2023

Documentation preview for this PR (built with commit 166eb13; changes) is ready! 🎉

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 5, 2023

Thanks!

@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 5, 2023
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 7, 2023
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Fixes failure seen in https://github.com/sagemath/sage/actions/runs/6700
323362/job/18206090971:
```
Error: Your Xcode (11.7 =>
/Applications/Xcode_11.7.app/Contents/Developer) is too outdated.
Please update to Xcode 13.2.1 (or delete it).
```

Makes the "dist" job work correctly when pushing a non-annotated tag,
fixing a failure seen in https://github.com/mkoeppe/sage/actions/runs/67
57396979/job/18367916600#step:5:11

Workflow run with this PR:
https://github.com/mkoeppe/sage/actions/runs/6757935604


<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36648
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit 9d2750c into sagemath:develop Nov 10, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants