Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prompt_toolkit: Set version constraint for conda #36659

Merged
merged 1 commit into from
Nov 10, 2023
Merged

prompt_toolkit: Set version constraint for conda #36659

merged 1 commit into from
Nov 10, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Nov 5, 2023

Replaces #36560.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Nov 5, 2023
@mkoeppe mkoeppe mentioned this pull request Nov 5, 2023
Closed
5 tasks
@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Documentation preview for this PR (built with commit 7dabb0a; changes) is ready! 🎉

tobiasdiez
tobiasdiez reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only in the conda file and not also in install_requires?

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 7, 2023

Because it's already there

@mkoeppe mkoeppe mentioned this pull request Nov 7, 2023
Closed
5 tasks
@mkoeppe mkoeppe requested a review from dimpase November 7, 2023 17:17
dimpase
dimpase approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 7, 2023

Thanks!

@vbraun vbraun merged commit 781dbff into sagemath:develop Nov 10, 2023
29 of 41 checks passed
@mkoeppe mkoeppe mentioned this pull request Nov 12, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez left review comments

@dimpase dimpase dimpase approved these changes

@isuruf isuruf Awaiting requested review from isuruf

Assignees

@mkoeppe mkoeppe

Labels
c: distribution p: blocker / 1
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkoeppe @dimpase @tobiasdiez @vbraun