Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/sage/graphs: some care with # optional #36682

Merged
merged 9 commits into from
Dec 10, 2023

Conversation

dcoudert
Copy link
Contributor

@dcoudert dcoudert commented Nov 9, 2023

Unify the syntax and ensure that we have 2 spaces before # optional.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's go

@fchapoton
Copy link
Contributor

fchapoton commented Nov 9, 2023

well, there are some failing doctests that could be related

@dcoudert
Copy link
Contributor Author

dcoudert commented Nov 9, 2023

well, there are some failing doctests that could be related

I suspect this is related to nauty and has nothing to do with this PR. I don't see these errors on macOS or Fedora 35...

@fchapoton
Copy link
Contributor

ok, then

@dcoudert
Copy link
Contributor Author

dcoudert commented Nov 9, 2023

Thanks.

@vbraun vbraun force-pushed the develop branch 2 times, most recently from 883e05f to e349b00 Compare November 12, 2023 16:25
Copy link

github-actions bot commented Dec 3, 2023

Documentation preview for this PR (built with commit c287566; changes) is ready! 🎉

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 7, 2023
    
Unify the syntax and ensure that we have 2 spaces before `# optional`.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36682
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
@vbraun vbraun merged commit 168719b into sagemath:develop Dec 10, 2023
14 of 17 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants