Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

less use of _an_element_impl #36689

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Conversation

fchapoton
Copy link
Contributor

replace some methods _an_element_impl by _an_element_

one little step on the long way towards getting rid of parent_old

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

Copy link

Documentation preview for this PR (built with commit bae71ff; changes) is ready! 馃帀

Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test failures are unrelated.

You may want to preempt a possible merge conflict with #36656

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 7, 2023
    
replace some methods `_an_element_impl` by `_an_element_`

one little step on the long way towards getting rid of `parent_old`

### 馃摑 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
    
URL: sagemath#36689
Reported by: Fr茅d茅ric Chapoton
Reviewer(s): Matthias K枚ppe
@vbraun vbraun merged commit afdac63 into sagemath:develop Dec 10, 2023
20 of 22 checks passed
@fchapoton fchapoton deleted the less_an_element_impl branch December 10, 2023 14:03
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants