-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
make modform rings for triangle groups use Algebras #36703
Merged
vbraun
merged 3 commits into
sagemath:develop
from
fchapoton:use_algebras_modform_triangle
Dec 10, 2023
Merged
make modform rings for triangle groups use Algebras #36703
vbraun
merged 3 commits into
sagemath:develop
from
fchapoton:use_algebras_modform_triangle
Dec 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7dc678c
to
5a0a079
Compare
kwankyu
reviewed
Nov 21, 2023
kwankyu
reviewed
Nov 21, 2023
kwankyu
reviewed
Nov 21, 2023
kwankyu
reviewed
Nov 21, 2023
Documentation preview for this PR (built with commit f70bfb2; changes) is ready! 馃帀 |
any other comment ? |
kwankyu
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps no.
thanks a lot for your reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is using the category framework in a few more rings, namely modular forms for triangle groups.
馃摑 Checklist