Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows/macos.yml: Fix syntax #36723

Merged
merged 1 commit into from
Nov 17, 2023
Merged

.github/workflows/macos.yml: Fix syntax #36723

merged 1 commit into from
Nov 17, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Nov 15, 2023 •
edited

#36711 introduced a syntax error that causes failures:
https://github.com/sagemath/sage/actions/runs/6870325982

Fixed here - as seen in https://github.com/mkoeppe/sage/actions/runs/6874334555

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 15, 2023
@mkoeppe mkoeppe self-assigned this Nov 15, 2023
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 1f572f8; changes) is ready! 🎉

@jhpalmieri
Copy link
Member

Sorry I missed that in #36711.

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 15, 2023

Thanks!

@vbraun vbraun merged commit dcd23be into sagemath:develop Nov 17, 2023
19 of 24 checks passed
@mkoeppe mkoeppe deleted the ci_macos_fixup branch December 23, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpalmieri jhpalmieri jhpalmieri approved these changes

@tobiasdiez tobiasdiez Awaiting requested review from tobiasdiez

Assignees

@mkoeppe mkoeppe

Labels
p: blocker / 1
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkoeppe @jhpalmieri @vbraun