Remove the pycygwin package #36779
Merged
Remove the pycygwin package #36779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimpase
approved these changes
Nov 26, 2023
|
No problem, I'm only splitting them to make it easier to review, so if you want to do it all at once with a flaming sword that's OK with me too. |
3 tasks
|
Please rebase on top of #36769. |
dimpase
force-pushed
the
drop-pycygwin-package
branch
from
108e02c
to
69636ca
Compare
|
Documentation preview for this PR (built with commit 69636ca; changes) is ready! 🎉 |
|
merge conflict |
|
merge conflict |
#36769 isn't yet in develop - how am I supposed to deal with this? |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 13, 2023
Removing Cygwin support from: - build system, - CI, - SPKG configuration and installation scripts, - Sage library. Depends on sagemath#36779 URL: sagemath#36778 Reported by: Michael Orlitzky Reviewer(s): Dima Pasechnik, Matthias Köppe, Michael Orlitzky, Tobias Diez
mkoeppe
force-pushed
the
drop-pycygwin-package
branch
from
5ea0e8e
to
6c2a5bc
Compare
|
rebased |
|
There's still some leftover cygwin stuff in src/sage/interfaces/jmoldata.py |
We're dropping Cygwin support, and in particular, the pycygwin library that handles these paths.
We're dropping Cygwin support, and in particular, the pycygwin library that handles these paths.
We're dropping Cygwin support, and in particular, the pycygwin library that handles these paths.
dimpase
force-pushed
the
drop-pycygwin-package
branch
from
6c2a5bc
to
d9460d3
Compare
dimpase
added
s: needs review
s: positive review
and removed
s: needs work
s: needs review
labels
|
|
should be ok now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only needed for Cygwin (to handle path conversions), and we're dropping Cygwin support for real now.
Depends on #36769