Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the headings of the databases section of the reference manual #36791

Merged
merged 12 commits into from
Dec 19, 2023
Merged

Improve the headings of the databases section of the reference manual #36791

merged 12 commits into from
Dec 19, 2023

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Nov 30, 2023 •
edited

This part of the reference manual is in poor state. We improve the look of the part.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu kwankyu changed the title Edit databases section Edit databases section of reference manual Nov 30, 2023
@kwankyu kwankyu changed the title Edit databases section of reference manual Edit databases section of the reference manual Nov 30, 2023
@kwankyu kwankyu changed the title Edit databases section of the reference manual Improve the headings of the databases section of the reference manual Dec 1, 2023
@mkoeppe
Copy link
Member

mkoeppe commented Dec 13, 2023 

 [sagemath_doc_html-none] OSError: /sage/src/sage/databases/cunningham_tables.py:docstring of sage.databases.cunningham_tables:1: WARNING: undefined label: 'cunningham_tables'

@kwankyu
Copy link
Collaborator Author

kwankyu commented Dec 13, 2023

Sorry! Fixed.

mkoeppe
mkoeppe approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@kwankyu
Copy link
Collaborator Author

kwankyu commented Dec 13, 2023

Thanks. I added links to the optional packages for the remaining two(three) databases.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit a4c3007; changes) is ready! 🎉

@kwankyu
Copy link
Collaborator Author

kwankyu commented Dec 13, 2023

Thanks for the review!

@vbraun vbraun merged commit 9deea7b into sagemath:develop Dec 19, 2023
18 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantepse mantepse mantepse left review comments

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
c: documentation
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kwankyu @mkoeppe @mantepse @vbraun