Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter failure in 10.3.beta0 #36822

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fix linter failure in 10.3.beta0 #36822

merged 1 commit into from
Dec 14, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Dec 6, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Dec 6, 2023
This was referenced Dec 6, 2023
Merged
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Documentation preview for this PR (built with commit 92ad155; changes) is ready! 🎉

@mkoeppe mkoeppe mentioned this pull request Dec 6, 2023
Open
5 tasks
fchapoton
fchapoton approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2023

Thanks

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 10, 2023
sagemathgh-36822: Fix linter failure in 10.3.beta0
417ae96 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36822
Reported by: Matthias Köppe
Reviewer(s): Frédéric Chapoton
@vbraun vbraun merged commit f2be975 into sagemath:develop Dec 14, 2023
19 of 22 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees

@mkoeppe mkoeppe

Labels
p: blocker / 1
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkoeppe @fchapoton @vbraun