Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved integer vectors efficiency -Enhancement #36830

Merged
merged 18 commits into from
Dec 19, 2023
Merged

improved integer vectors efficiency -Enhancement #36830

merged 18 commits into from
Dec 19, 2023

Commits on Dec 6, 2023

  1. added cardinality method to IntegerVectors_nk class

    @amanmoon
    amanmoon committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    dc62757 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. added an efficient cardinality function in IntegerVectors_nk and fixe… 

    …d bug of InfiniteEnumeratedSets and +infinity of IntegerVectors_n(0) and IntegerVectors_k(0)
    @amanmoon
    amanmoon committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    95a984e View commit details
    Browse the repository at this point in the history

  2. added rank, unrank and cardinality function in IntegerVectors, Intege… 

    …rVectors_n and IntegerVectors_k optimised rank and unrank function
    @amanmoon
    amanmoon committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    6c8c167 View commit details
    Browse the repository at this point in the history

  3. fixed typos and made code more redable

    @amanmoon
    amanmoon committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    42b5620 View commit details
    Browse the repository at this point in the history

  4. fixed more typos and made code redable

    @amanmoon
    amanmoon committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    db8dbd2 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. changed EXAMPLE to EXAMPLES

    @amanmoon
    amanmoon committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f536d45 View commit details
    Browse the repository at this point in the history

  2. made elif to if and added new EXAMPLES in IntegerVector_nk.cardinality()

    @amanmoon
    amanmoon committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    7fe22d1 View commit details
    Browse the repository at this point in the history

  3. formated Integer_vector.py according to sagemath guidelines

    @amanmoon
    amanmoon committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    167acc9 View commit details
    Browse the repository at this point in the history

  4. created helper function for unrank in IntegerVector

    @amanmoon
    amanmoon committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    cad751d View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. fixed the IndexError in IntegerVectors_n unrank method and made the I… 

    …ntegerVectors_k unrank method faster
    @amanmoon
    amanmoon committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    48c188d View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. changed the name of unrank(helper) function and removed unnecessary e… 

    …lse statements
    @amanmoon
    amanmoon committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    ec8cb35 View commit details
    Browse the repository at this point in the history

  2. added the else statement

    @amanmoon
    amanmoon committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    2f1e749 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Merge branch 'sagemath:develop' into enhancement/IntegerVectors_effic… 

    …iency
    @amanmoon
    amanmoon committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    314c257 View commit details
    Browse the repository at this point in the history

  2. added examples in _unrank_helper method and corner cases test

    @amanmoon
    amanmoon committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    246b6d6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'enhancement/IntegerVectors_efficiency' of into enhancem… 

    …ent/IntegerVectors_efficiency
    @amanmoon
    amanmoon committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    fcfb917 View commit details
    Browse the repository at this point in the history

  4. corrected typos and indentation

    @amanmoon
    amanmoon committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    2fb35a6 View commit details
    Browse the repository at this point in the history

  5. put the description of _unrank_helper at start of the method

    @amanmoon
    amanmoon committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    847b705 View commit details
    Browse the repository at this point in the history

  6. implemented alternate way of looping in the rank method

    @amanmoon
    amanmoon committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    dedee8d View commit details
    Browse the repository at this point in the history