Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.groups, sage.rings.number_field: Modularization fixes, # needs #36865

Merged
merged 23 commits into from
Dec 19, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Dec 12, 2023

Standard modularization work:

  • a new dynamically detected feature sage.libs.braiding
  • using file-level and block-level # needs to simplify decorations
  • adding some # needs, in particular for sage.libs.gap
  • splitting GAP-dependent classes out from sage.groups.galois_group
  • using more lazy_imports
  • some doctest cosmetics

Part of:

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to list the new file galois_group_perm.py in the right .rst file so that it appear in https://doc.sagemath.org/html/en/reference/groups/index.html ?

otherwise, LGTM.

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 13, 2023

Also galois_group does not appear in any index.rst. I'm not sure if this was intentional

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The addition to the appropriate place in some index.rst file can be done later.

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 13, 2023

Thank you!

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 14, 2023

rebased

Copy link

Documentation preview for this PR (built with commit 1d77a49; changes) is ready! 🎉

@vbraun vbraun merged commit ba40387 into sagemath:develop Dec 19, 2023
16 of 17 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants