Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruff and pep E275 fixes in misc #36874

Merged
merged 3 commits into from
Dec 26, 2023
Merged

ruff and pep E275 fixes in misc #36874

merged 3 commits into from
Dec 26, 2023

Conversation

fchapoton
Copy link
Contributor

Some fixes performed by ruff in the misc folder.

Also manually fixing some pycodestyle E275

Also adding a few links for errors in the doc

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@dimpase
Copy link
Member

dimpase commented Dec 13, 2023 •
edited
Loading

is this

sage -t --random-seed=199162918320468470414109962175876556485 src/sage/misc/lazy_attribute.pyx
**********************************************************************
File "src/sage/misc/lazy_attribute.pyx", line 89, in sage.misc.lazy_attribute._lazy_attribute._sage_src_lines_
Failed example:
    lines
Expected:
    89
Got:
    88

a byproduct of your changes?

and

File "src/sage/misc/abstract_method.py", line 195, in sage.misc.abstract_method.AbstractMethod._sage_src_lines_
Failed example:
    lines
Expected:
    19
Got:
    18

?

@fchapoton
Copy link
Contributor Author

yes, indeed. It comes from the removal of the first line in the file banner.py

I have fixed these 2 doctests.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 00b3ef1; changes) is ready! 🎉

mkoeppe
mkoeppe approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 21, 2023
sagemathgh-36874: ruff and pep E275 fixes in misc
1d69847 
    
Some fixes performed by `ruff` in the `misc` folder.

Also manually fixing some pycodestyle E275

Also adding a few links for errors in the doc

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36874
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 22, 2023
sagemathgh-36874: ruff and pep E275 fixes in misc
3618281 
    
Some fixes performed by `ruff` in the `misc` folder.

Also manually fixing some pycodestyle E275

Also adding a few links for errors in the doc

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36874
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 23, 2023
sagemathgh-36874: ruff and pep E275 fixes in misc
0c17428 
    
Some fixes performed by `ruff` in the `misc` folder.

Also manually fixing some pycodestyle E275

Also adding a few links for errors in the doc

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36874
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 24, 2023
sagemathgh-36874: ruff and pep E275 fixes in misc
a8fe5c6 
    
Some fixes performed by `ruff` in the `misc` folder.

Also manually fixing some pycodestyle E275

Also adding a few links for errors in the doc

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36874
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit 8b7ef42 into sagemath:develop Dec 26, 2023
21 of 22 checks passed
@fchapoton fchapoton deleted the ruff_misc_UP branch December 26, 2023 13:15
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchapoton @dimpase @mkoeppe @vbraun