Improve code style for matrix2.pyx file #36877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected code style according to sagemath standards.
…_row_sums() function This commit removes check condition for column number that whether the column number is not exceeding the index but this is done somewhere else and no longer needed. And this corrects pycodestyle of file matrix2.pyx
…function This commit improves code style further and removes a if condition in restrict() function.
Improves code style of the file matrix2.pyx
Improving code style for the file matrix2.pyx
Improved the code style for matrix2.pyx file.
Final commit for the improved code style for matrix2.pyx file.
|
Adding the missing whitespace after commas is much too intrusive to be done systematically, and in particular in huge files such as the one touched here. To say that otherwise, we are not doing that, except just one in passing when modifying the code for other reasons. |
|
Hmm.. got it. Actually, I was modifying the code of this file when I saw this, so I thought it would be better to correct that. |
4 tasks
|
@fchapoton, can you please help me find out what the problem is with the build and test check? |
|
Documentation preview for this PR (built with commit 1f663cb; changes) is ready! 🎉 |
There is no problem. Ignore conda tests. |
|
Ok, thank you ! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 5, 2024
- Correct pycodestyle and remove check condition for columns in prod_of_row_sums() function - Improve code style and remove an unwanted if condition in restrict() function - Improve code style of matrix2.pyx file - Improve code style for matrix2.pyx This patch improves the code style as mentioned in the sage documentation and removes some unnecessary lines which were commented before and was not removed. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> None URL: sagemath#36877 Reported by: Ruchit Jagodara Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the code style as mentioned in the sage documentation and removes
some unnecessary lines which were commented before and was not removed.
📝 Checklist
⌛ Dependencies
None