update eclib to version 20231212 #36879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I can see, the test failures have nothing to do with my changes. |
|
How about this one (on 32bit) (https://github.com/sagemath/sage/actions/runs/7212244941/job/19649586297?pr=36879#step:11:10473) |
I don't think any of that code is changed. It was not written by me -- it is a translation into cython of code in eclib (in C++), and is almost certainly now available directly on pari which has a lot more elliptic curve functionality than when this was written. ANyway, I ca't see anything wrong with the function, but I am no cython expert. |
|
As with my other oper PR, there appear to be failing tests which have nothing to do with any code I changed. Of course I may be wrong. |
|
Documentation preview for this PR (built with commit a54dcee; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 21, 2023
eclib version 20231212 has some bugfixes and also uses flint3 if available. No Sage code or doctest changes are required. build/pkgs/eclib/spkg-install.in has been simplified buid/pkgs/eclib/spkg-configure.m4 now uses [ge] and not [eq] to check eclib version ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36879 Reported by: John Cremona Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 22, 2023
eclib version 20231212 has some bugfixes and also uses flint3 if available. No Sage code or doctest changes are required. build/pkgs/eclib/spkg-install.in has been simplified buid/pkgs/eclib/spkg-configure.m4 now uses [ge] and not [eq] to check eclib version ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36879 Reported by: John Cremona Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 23, 2023
eclib version 20231212 has some bugfixes and also uses flint3 if available. No Sage code or doctest changes are required. build/pkgs/eclib/spkg-install.in has been simplified buid/pkgs/eclib/spkg-configure.m4 now uses [ge] and not [eq] to check eclib version ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36879 Reported by: John Cremona Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 24, 2023
eclib version 20231212 has some bugfixes and also uses flint3 if available. No Sage code or doctest changes are required. build/pkgs/eclib/spkg-install.in has been simplified buid/pkgs/eclib/spkg-configure.m4 now uses [ge] and not [eq] to check eclib version ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36879 Reported by: John Cremona Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclib version 20231212 has some bugfixes and also uses flint3 if available. No Sage code or doctest changes are required.
build/pkgs/eclib/spkg-install.in has been simplified
buid/pkgs/eclib/spkg-configure.m4 now uses [ge] and not [eq] to check eclib version
📝 Checklist
⌛ Dependencies