Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cardinality of special linear group #36881

Merged
merged 13 commits into from
Feb 13, 2024
Merged

Fix cardinality of special linear group #36881

merged 13 commits into from
Feb 13, 2024

Commits on Feb 9, 2024

  1. Fixed infinite recursion of the cardinality and order functions 

    In this commit, I have fixed the :trac:`36876` and :trac:`35490`.
And I have also added some doc tests covering this changes.
    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    a9e2b74 View commit details
    Browse the repository at this point in the history

  2. Add more doctests to cover all cases 

    Added more doctests.
    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    0101a8d View commit details
    Browse the repository at this point in the history

  3. Corrected lint error

    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    b0f3988 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary comments

    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    2dc4a32 View commit details
    Browse the repository at this point in the history

  5. Correct the error in finding cardinality of special linear group 

    Corrected the error of previous commit.
    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d4eb8ed View commit details
    Browse the repository at this point in the history

  6. Revert all the changes

    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    df64b41 View commit details
    Browse the repository at this point in the history

  7. Add a new order method for linear matrix groups

    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d15eb8f View commit details
    Browse the repository at this point in the history

  8. Corrected a linting error

    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e2840ed View commit details
    Browse the repository at this point in the history

  9. Fixed a doctest

    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    84077dc View commit details
    Browse the repository at this point in the history

  10. Fixed few linting errors

    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    a13d56a View commit details
    Browse the repository at this point in the history

  11. Improved coding style

    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    1781ad3 View commit details
    Browse the repository at this point in the history

  12. Shifted the position of import statements

    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4b7bac3 View commit details
    Browse the repository at this point in the history

  13. Fixed documentation of minimal_normal_subgroups function

    @RuchitJagodara
    RuchitJagodara committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    baa3b50 View commit details
    Browse the repository at this point in the history