Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing one bug in the use of valuation #36882

Merged
merged 2 commits into from
Dec 26, 2023
Merged

fixing one bug in the use of valuation #36882

merged 2 commits into from
Dec 26, 2023

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Dec 14, 2023 •
edited

Trying to divide by an integer was failing here:

sage: L=PowerSeriesRing(QQ,'t')
sage: t=L.gen()
sage: F=algebras.Free(L,['A','B','C'])
sage: A,B,C=F.gens()
sage: f=t*A+t**2*B/2  # BUG HERE

and the same for Lazy power series.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have created tests covering the changes.

tscrim
tscrim reviewed Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the one comment on _Fields().

src/sage/modules/with_basis/indexed_element.pyx Outdated Show resolved Hide resolved
@tscrim
Copy link
Collaborator

tscrim commented Dec 19, 2023

Thanks. Although it looks like something went wrong with a merge or rebase.

@fchapoton
Copy link
Contributor Author

indeed, should be better now

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit c74f555; changes) is ready! 🎉

tscrim
tscrim approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 21, 2023
sagemathgh-36882: fixing one bug in the use of valuation
d7fa55e 
    
Trying to divide by an integer was failing here:

```
sage: L=PowerSeriesRing(QQ,'t')
sage: t=L.gen()
sage: F=algebras.Free(L,['A','B','C'])
sage: A,B,C=F.gens()
sage: f=t*A+t**2*B/2  # BUG HERE
```

and the same for Lazy power series.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have created tests covering the changes.
    
URL: sagemath#36882
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 22, 2023
sagemathgh-36882: fixing one bug in the use of valuation
6733d6e 
    
Trying to divide by an integer was failing here:

```
sage: L=PowerSeriesRing(QQ,'t')
sage: t=L.gen()
sage: F=algebras.Free(L,['A','B','C'])
sage: A,B,C=F.gens()
sage: f=t*A+t**2*B/2  # BUG HERE
```

and the same for Lazy power series.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have created tests covering the changes.
    
URL: sagemath#36882
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 23, 2023
sagemathgh-36882: fixing one bug in the use of valuation
83e11b8 
    
Trying to divide by an integer was failing here:

```
sage: L=PowerSeriesRing(QQ,'t')
sage: t=L.gen()
sage: F=algebras.Free(L,['A','B','C'])
sage: A,B,C=F.gens()
sage: f=t*A+t**2*B/2  # BUG HERE
```

and the same for Lazy power series.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have created tests covering the changes.
    
URL: sagemath#36882
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 24, 2023
sagemathgh-36882: fixing one bug in the use of valuation
7cddb2e 
    
Trying to divide by an integer was failing here:

```
sage: L=PowerSeriesRing(QQ,'t')
sage: t=L.gen()
sage: F=algebras.Free(L,['A','B','C'])
sage: A,B,C=F.gens()
sage: f=t*A+t**2*B/2  # BUG HERE
```

and the same for Lazy power series.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have created tests covering the changes.
    
URL: sagemath#36882
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 25, 2023
sagemathgh-36882: fixing one bug in the use of valuation
be5cfaa 
Trying to divide by an integer was failing here:

```
sage: L=PowerSeriesRing(QQ,'t')
sage: t=L.gen()
sage: F=algebras.Free(L,['A','B','C'])
sage: A,B,C=F.gens()
sage: f=t*A+t**2*B/2  # BUG HERE
```

and the same for Lazy power series.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have created tests covering the changes.

URL: sagemath#36882
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 5d7d2e3 into sagemath:develop Dec 26, 2023
18 of 20 checks passed
@fchapoton fchapoton deleted the fix_valuation_usage branch December 26, 2023 13:15
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: commutative algebra t: bug
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchapoton @tscrim @vbraun @mkoeppe