Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/sage/modular/arithgroup/farey.cpp: Fix #include for farey_symbol.h #36883

Merged
merged 1 commit into from
Dec 19, 2023
Merged

src/sage/modular/arithgroup/farey.cpp: Fix #include for farey_symbol.h #36883

merged 1 commit into from
Dec 19, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Dec 14, 2023

This reverts one change of #36754, which broke building sagemath-standard as reported in #36754 (comment)

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Dec 14, 2023
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 6d76fd6; changes) is ready! 🎉

@tornaria
Copy link
Contributor

LGTM, thanks.

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 14, 2023

Thanks!

@kiwifb
Copy link
Member

kiwifb commented Dec 14, 2023

And thank you for opening the PR and supporting us using sagemath-standard.

@vbraun vbraun merged commit 8ba4c46 into sagemath:develop Dec 19, 2023
22 of 23 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiwifb kiwifb Awaiting requested review from kiwifb

@tornaria tornaria Awaiting requested review from tornaria

Assignees

@mkoeppe mkoeppe

Labels
p: blocker / 1
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkoeppe @tornaria @kiwifb @vbraun