Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/sage/game_theory/: fix doctest warnings due to modularization #36904

Merged
merged 3 commits into from
Dec 26, 2023
Merged

src/sage/game_theory/: fix doctest warnings due to modularization #36904

merged 3 commits into from
Dec 26, 2023

Conversation

dcoudert
Copy link
Contributor

Use more block-scope tags to avoid doctest warnings like

File "src/sage/game_theory/normal_form_game.py", line 1093, in sage.game_theory.normal_form_game.NormalFormGame._gambit_
Warning: Consider using a block-scoped tag by inserting the line 'sage: # optional - gambit' just before this line to avoid repeating the tag 29 times
    threegame = NormalFormGame() # optional - gambit

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@dcoudert dcoudert self-assigned this Dec 17, 2023
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit e85c02f; changes) is ready! 🎉

mkoeppe
mkoeppe approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 21, 2023
sagemathgh-36904: src/sage/game_theory/: fix doctest warnings due t…
f9bbf50 
…o modularization

    
Use more block-scope tags to avoid doctest warnings like
```
File "src/sage/game_theory/normal_form_game.py", line 1093, in
sage.game_theory.normal_form_game.NormalFormGame._gambit_
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# optional - gambit' just before this line to avoid repeating the tag 29
times
    threegame = NormalFormGame() # optional - gambit
```

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36904
Reported by: David Coudert
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 22, 2023
sagemathgh-36904: src/sage/game_theory/: fix doctest warnings due t…
bde7dc6 
…o modularization

    
Use more block-scope tags to avoid doctest warnings like
```
File "src/sage/game_theory/normal_form_game.py", line 1093, in
sage.game_theory.normal_form_game.NormalFormGame._gambit_
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# optional - gambit' just before this line to avoid repeating the tag 29
times
    threegame = NormalFormGame() # optional - gambit
```

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36904
Reported by: David Coudert
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 23, 2023
sagemathgh-36904: src/sage/game_theory/: fix doctest warnings due t…
0c4be9f 
…o modularization

    
Use more block-scope tags to avoid doctest warnings like
```
File "src/sage/game_theory/normal_form_game.py", line 1093, in
sage.game_theory.normal_form_game.NormalFormGame._gambit_
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# optional - gambit' just before this line to avoid repeating the tag 29
times
    threegame = NormalFormGame() # optional - gambit
```

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36904
Reported by: David Coudert
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 24, 2023
sagemathgh-36904: src/sage/game_theory/: fix doctest warnings due t…
2064082 
…o modularization

    
Use more block-scope tags to avoid doctest warnings like
```
File "src/sage/game_theory/normal_form_game.py", line 1093, in
sage.game_theory.normal_form_game.NormalFormGame._gambit_
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# optional - gambit' just before this line to avoid repeating the tag 29
times
    threegame = NormalFormGame() # optional - gambit
```

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36904
Reported by: David Coudert
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit a1db8a4 into sagemath:develop Dec 26, 2023
23 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 26, 2023
@mkoeppe mkoeppe mentioned this pull request Dec 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees

@dcoudert dcoudert

Labels
c: game theory t: refactoring
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dcoudert @mkoeppe @vbraun