src/sage/{categories,coding,plot,quadratic_forms}/: Fix various doctest warnings
#36905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 680c996; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 21, 2023
…`: Fix various doctest warnings
We fix the following warnings
```
File "src/sage/categories/finite_complex_reflection_groups.py", line
558, in sage.categories.finite_complex_reflection_groups.FiniteComplexRe
flectionGroups.ParentMethods.milnor_fiber_poset
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# optional - gap3' just before this line to avoid repeating the tag 4
times
W = ReflectionGroup(4) # optional - gap3
**********************************************************************
File "src/sage/categories/finite_complex_reflection_groups.py", line
565, in sage.categories.finite_complex_reflection_groups.FiniteComplexRe
flectionGroups.ParentMethods.milnor_fiber_poset
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# optional - gap3' just before this line to avoid repeating the tag 6
times
W = ReflectionGroup([4,2,2]) # optional - gap3
File "src/sage/coding/ag_code_decoders.pyx", line 32, in
sage.coding.ag_code_decoders
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# long time' just before this line to avoid repeating the tag 9 times
channel = channels.StaticErrorRateChannel(code.ambient_space(), tau)
# long time
File "src/sage/plot/graphics.py", line 1819, in
sage.plot.graphics.Graphics.show
Warning: Variable 'G' referenced here was set only in doctest marked '#
needs sage.symbolic'; '# long time, needs sage.symbolic'
G.show(scale='semilogy') #
long time
File "src/sage/quadratic_forms/ternary_qf.py", line 924, in
sage.quadratic_forms.ternary_qf.TernaryQF.find_p_neighbor_from_vec
Warning: Variable 'Q' referenced here was set only in doctest marked '#
needs sage.libs.pari'
Q.find_p_neighbor_from_vec(3, (0,0,1))
[315 tests, 0.38 s]
```
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36905
Reported by: David Coudert
Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 22, 2023
…`: Fix various doctest warnings
We fix the following warnings
```
File "src/sage/categories/finite_complex_reflection_groups.py", line
558, in sage.categories.finite_complex_reflection_groups.FiniteComplexRe
flectionGroups.ParentMethods.milnor_fiber_poset
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# optional - gap3' just before this line to avoid repeating the tag 4
times
W = ReflectionGroup(4) # optional - gap3
**********************************************************************
File "src/sage/categories/finite_complex_reflection_groups.py", line
565, in sage.categories.finite_complex_reflection_groups.FiniteComplexRe
flectionGroups.ParentMethods.milnor_fiber_poset
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# optional - gap3' just before this line to avoid repeating the tag 6
times
W = ReflectionGroup([4,2,2]) # optional - gap3
File "src/sage/coding/ag_code_decoders.pyx", line 32, in
sage.coding.ag_code_decoders
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# long time' just before this line to avoid repeating the tag 9 times
channel = channels.StaticErrorRateChannel(code.ambient_space(), tau)
# long time
File "src/sage/plot/graphics.py", line 1819, in
sage.plot.graphics.Graphics.show
Warning: Variable 'G' referenced here was set only in doctest marked '#
needs sage.symbolic'; '# long time, needs sage.symbolic'
G.show(scale='semilogy') #
long time
File "src/sage/quadratic_forms/ternary_qf.py", line 924, in
sage.quadratic_forms.ternary_qf.TernaryQF.find_p_neighbor_from_vec
Warning: Variable 'Q' referenced here was set only in doctest marked '#
needs sage.libs.pari'
Q.find_p_neighbor_from_vec(3, (0,0,1))
[315 tests, 0.38 s]
```
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36905
Reported by: David Coudert
Reviewer(s): Matthias Köppe
Merged
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 23, 2023
…`: Fix various doctest warnings
We fix the following warnings
```
File "src/sage/categories/finite_complex_reflection_groups.py", line
558, in sage.categories.finite_complex_reflection_groups.FiniteComplexRe
flectionGroups.ParentMethods.milnor_fiber_poset
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# optional - gap3' just before this line to avoid repeating the tag 4
times
W = ReflectionGroup(4) # optional - gap3
**********************************************************************
File "src/sage/categories/finite_complex_reflection_groups.py", line
565, in sage.categories.finite_complex_reflection_groups.FiniteComplexRe
flectionGroups.ParentMethods.milnor_fiber_poset
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# optional - gap3' just before this line to avoid repeating the tag 6
times
W = ReflectionGroup([4,2,2]) # optional - gap3
File "src/sage/coding/ag_code_decoders.pyx", line 32, in
sage.coding.ag_code_decoders
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# long time' just before this line to avoid repeating the tag 9 times
channel = channels.StaticErrorRateChannel(code.ambient_space(), tau)
# long time
File "src/sage/plot/graphics.py", line 1819, in
sage.plot.graphics.Graphics.show
Warning: Variable 'G' referenced here was set only in doctest marked '#
needs sage.symbolic'; '# long time, needs sage.symbolic'
G.show(scale='semilogy') #
long time
File "src/sage/quadratic_forms/ternary_qf.py", line 924, in
sage.quadratic_forms.ternary_qf.TernaryQF.find_p_neighbor_from_vec
Warning: Variable 'Q' referenced here was set only in doctest marked '#
needs sage.libs.pari'
Q.find_p_neighbor_from_vec(3, (0,0,1))
[315 tests, 0.38 s]
```
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36905
Reported by: David Coudert
Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 24, 2023
…`: Fix various doctest warnings
We fix the following warnings
```
File "src/sage/categories/finite_complex_reflection_groups.py", line
558, in sage.categories.finite_complex_reflection_groups.FiniteComplexRe
flectionGroups.ParentMethods.milnor_fiber_poset
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# optional - gap3' just before this line to avoid repeating the tag 4
times
W = ReflectionGroup(4) # optional - gap3
**********************************************************************
File "src/sage/categories/finite_complex_reflection_groups.py", line
565, in sage.categories.finite_complex_reflection_groups.FiniteComplexRe
flectionGroups.ParentMethods.milnor_fiber_poset
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# optional - gap3' just before this line to avoid repeating the tag 6
times
W = ReflectionGroup([4,2,2]) # optional - gap3
File "src/sage/coding/ag_code_decoders.pyx", line 32, in
sage.coding.ag_code_decoders
Warning: Consider using a block-scoped tag by inserting the line 'sage:
# long time' just before this line to avoid repeating the tag 9 times
channel = channels.StaticErrorRateChannel(code.ambient_space(), tau)
# long time
File "src/sage/plot/graphics.py", line 1819, in
sage.plot.graphics.Graphics.show
Warning: Variable 'G' referenced here was set only in doctest marked '#
needs sage.symbolic'; '# long time, needs sage.symbolic'
G.show(scale='semilogy') #
long time
File "src/sage/quadratic_forms/ternary_qf.py", line 924, in
sage.quadratic_forms.ternary_qf.TernaryQF.find_p_neighbor_from_vec
Warning: Variable 'Q' referenced here was set only in doctest marked '#
needs sage.libs.pari'
Q.find_p_neighbor_from_vec(3, (0,0,1))
[315 tests, 0.38 s]
```
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36905
Reported by: David Coudert
Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 24, 2023
…ix `sig_on_count` doctest dataflow warnings
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Fixes sagemath#36920
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
In part cherry picked from:
- sagemath#35095
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36905 (merged here)
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36950
Reported by: Matthias Köppe
Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 26, 2023
…ix `sig_on_count` doctest dataflow warnings
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Fixes sagemath#36920
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
In part cherry picked from:
- sagemath#35095
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36905 (merged here)
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36950
Reported by: Matthias Köppe
Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fix the following warnings
📝 Checklist
⌛ Dependencies