using less isinstance(..., Ring) #36922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
reviewed
Dec 19, 2023
mkoeppe
reviewed
Dec 19, 2023
|
Documentation preview for this PR (built with commit 1272029; changes) is ready! 馃帀 |
mkoeppe
reviewed
Dec 20, 2023
| if category is None: | ||
| homset_cat = A.category() | ||
| else: | ||
| homset_cat = category | ||
| # Remark: Ring.__init__ will automatically form the join | ||
| # Remark: Parent.__init__ will automatically form the join | ||
| # of the category of rings and of homset_cat |
There was a problem hiding this comment.
does it? or is that done by Endsets()?
There was a problem hiding this comment.
Well, that's the line Parent.__init __ that does the job. Once done, the categories contains that of "rings". The next line does not change anything to the list of categories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in favour of the more categorical
... in Rings()also fixing a few pep8 details in passing but not too much
馃摑 Checklist