Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/sage/combinat/designs/subhypergraph_search.pyx: constness fix for clang 16 #36927

Merged
merged 1 commit into from
Feb 13, 2024
Merged

src/sage/combinat/designs/subhypergraph_search.pyx: constness fix for clang 16 #36927

merged 1 commit into from
Feb 13, 2024

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Dec 19, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Dec 19, 2023
@mkoeppe mkoeppe mentioned this pull request Dec 20, 2023
Closed
2 tasks
@mkoeppe mkoeppe requested a review from dimpase December 21, 2023 17:35
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit fc6b33e; changes) is ready! 🎉

kwankyu
kwankyu approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ventured to try conda with clang v16. Yes, the fix here makes the conda build pass the error point.

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 8, 2024

Thanks!

@vbraun vbraun merged commit 20a6fde into sagemath:develop Feb 13, 2024
19 of 20 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@dimpase dimpase Awaiting requested review from dimpase

Assignees

@mkoeppe mkoeppe

Labels
c: porting
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkoeppe @kwankyu @vbraun